From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24302 invoked by alias); 26 Jun 2009 17:30:48 -0000 Received: (qmail 24291 invoked by uid 22791); 26 Jun 2009 17:30:45 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Jun 2009 17:30:40 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.14.3/8.13.8) with ESMTP id n5QHUEiL094718 for ; Fri, 26 Jun 2009 17:30:14 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n5QHUET22351114 for ; Fri, 26 Jun 2009 19:30:14 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n5QHUEbv004614 for ; Fri, 26 Jun 2009 19:30:14 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n5QHUDAv004603; Fri, 26 Jun 2009 19:30:13 +0200 Message-Id: <200906261730.n5QHUDAv004603@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Fri, 26 Jun 2009 19:30:13 +0200 Subject: Re: [6/7] Introduce per-type architecture To: tromey@redhat.com Date: Fri, 26 Jun 2009 17:30:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00748.txt.bz2 Tom Tromey wrote: > I read through this patch series. Well... I skimmed most of it, since > it mostly seemed mechanical. > > It all seems reasonable to me. Thanks for the review. > I noticed that many of the new functions don't have introductory > comments. We've been asking everybody to write these recently; and I > think the quoted text here would be good to have in the code > somewhere. So, I would like to ask that this be split up and attached > to the appropriate functions. You're right. I'll be happy to add such comments. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com