From: Daniel Jacobowitz <drow@false.org>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Use LONGEST instead of value for index arithmetic
Date: Fri, 26 Jun 2009 16:00:00 -0000 [thread overview]
Message-ID: <20090626160033.GA16047@caradoc.them.org> (raw)
In-Reply-To: <200906261549.n5QFn7x1026331@d12av02.megacenter.de.ibm.com>
On Fri, Jun 26, 2009 at 05:49:07PM +0200, Ulrich Weigand wrote:
> Hello,
>
> this patch implements the change I mentioned recently: use LONGEST instead
> of struct value to represent array indexes (and similarly the integer
> operands to pointer arithmetic). This has the advantage that index
> computations can be performed in host instead of target arithmetic,
> and not just eliminates a bunch of references to global built-in types,
> but makes both implementation and users of the value_subscript and
> pointer arithmetic routines quite a bit simpler.
Looks good to me. I noticed you're removing several error calls; do
those garbage cases still produce some error message? I guess they
must be untested :-(
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-06-26 16:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-26 15:49 Ulrich Weigand
2009-06-26 16:00 ` Daniel Jacobowitz [this message]
2009-06-26 16:50 ` Ulrich Weigand
2009-06-26 18:21 ` Daniel Jacobowitz
2009-06-29 13:26 ` Ulrich Weigand
2009-06-26 16:40 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090626160033.GA16047@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox