From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13341 invoked by alias); 26 Jun 2009 16:00:45 -0000 Received: (qmail 13329 invoked by uid 22791); 26 Jun 2009 16:00:43 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Jun 2009 16:00:37 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 2D07B1062D; Fri, 26 Jun 2009 16:00:35 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 0362A105BB; Fri, 26 Jun 2009 16:00:35 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1MKDqs-0004GI-0D; Fri, 26 Jun 2009 12:00:34 -0400 Date: Fri, 26 Jun 2009 16:00:00 -0000 From: Daniel Jacobowitz To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [rfc] Use LONGEST instead of value for index arithmetic Message-ID: <20090626160033.GA16047@caradoc.them.org> Mail-Followup-To: Ulrich Weigand , gdb-patches@sourceware.org References: <200906261549.n5QFn7x1026331@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200906261549.n5QFn7x1026331@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00726.txt.bz2 On Fri, Jun 26, 2009 at 05:49:07PM +0200, Ulrich Weigand wrote: > Hello, > > this patch implements the change I mentioned recently: use LONGEST instead > of struct value to represent array indexes (and similarly the integer > operands to pointer arithmetic). This has the advantage that index > computations can be performed in host instead of target arithmetic, > and not just eliminates a bunch of references to global built-in types, > but makes both implementation and users of the value_subscript and > pointer arithmetic routines quite a bit simpler. Looks good to me. I noticed you're removing several error calls; do those garbage cases still produce some error message? I guess they must be untested :-( -- Daniel Jacobowitz CodeSourcery