Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [RFA]: Update psymtab.exp for change in not found method handling
@ 2009-06-26  5:31 Doug Evans
  2009-06-26 14:55 ` Pedro Alves
  0 siblings, 1 reply; 2+ messages in thread
From: Doug Evans @ 2009-06-26  5:31 UTC (permalink / raw)
  To: gdb-patches; +Cc: karen.osmond

Hi.

psymtab.exp is failing now (amd64-linux).

2009-06-25  Karen Osmond  <karen.osmond@gmail.com>

	* linespec.c (find_method): Add new not_found_ptr parameter to
	bring in line with symtab_from_filename, decode_variable.
	(decode_compound): Likewise.  Also propagate not_found_ptr to 
	find_method.
	(decode_line_1): Propagate not_found_ptr to decode_compound.
	(cplusplus_error): Now throws NOT_FOUND_ERROR.

gdb now prompts for whether to set pending method breakpoints
and psymtab.exp isn't expecting this.

ok to check in?

2009-06-25  Doug Evans  <dje@google.com>

	* gdb.base/psymtab.exp: Turn off pending breakpoints.

Index: psymtab.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/psymtab.exp,v
retrieving revision 1.7
diff -u -p -r1.7 psymtab.exp
--- psymtab.exp	3 Jan 2009 05:58:03 -0000	1.7
+++ psymtab.exp	26 Jun 2009 05:18:25 -0000
@@ -61,6 +61,11 @@ gdb_start
 gdb_reinitialize_dir $srcdir/$subdir
 gdb_load ${binfile}
 
+# Disable the prompt for whether to set pending breakpoints.
+# We don't want a breakpoint, we just want to verify the breakpoint
+# isn't found.
+gdb_test "set breakpoint pending off" "" "psymtab pending setup"
+
 # This test is looking for a bug that manifested itself when GDB was
 # looking for a partial symbol such that there wasn't such a partial
 # symbol in the psymtab, but such that the last psym in the psymtab


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [RFA]: Update psymtab.exp for change in not found method handling
  2009-06-26  5:31 [RFA]: Update psymtab.exp for change in not found method handling Doug Evans
@ 2009-06-26 14:55 ` Pedro Alves
  0 siblings, 0 replies; 2+ messages in thread
From: Pedro Alves @ 2009-06-26 14:55 UTC (permalink / raw)
  To: gdb-patches; +Cc: Doug Evans, karen.osmond, Jan Kratochvil

On Friday 26 June 2009 06:31:22, Doug Evans wrote:
> Hi.
> 
> psymtab.exp is failing now (amd64-linux).

> gdb now prompts for whether to set pending method breakpoints
> and psymtab.exp isn't expecting this.

Linking the messages: Jan also posted a patch for this.

 http://sourceware.org/ml/gdb-patches/2009-06/msg00703.html

> ok to check in?

> 2009-06-25  Doug Evans  <dje@google.com>
> 
> 	* gdb.base/psymtab.exp: Turn off pending breakpoints.

Okay.

> +# Disable the prompt for whether to set pending breakpoints.
> +# We don't want a breakpoint, we just want to verify the breakpoint

                                                            ^^^^^^^^^^ symbol ?
> +# isn't found.

-- 
Pedro Alves


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-06-26 14:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-26  5:31 [RFA]: Update psymtab.exp for change in not found method handling Doug Evans
2009-06-26 14:55 ` Pedro Alves

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox