From: Daniel Jacobowitz <drow@false.org>
To: Cary Coutant <ccoutant@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: DWARF is_stmt flag (revisited)
Date: Tue, 23 Jun 2009 18:49:00 -0000 [thread overview]
Message-ID: <20090623184858.GB3179@caradoc.them.org> (raw)
In-Reply-To: <c17be2b30906161139x1c37b0fcofe17a1ede443c2b3@mail.gmail.com>
On Tue, Jun 16, 2009 at 11:39:05AM -0700, Cary Coutant wrote:
> Longer term, I think that gdb will need to record the is_stmt flag
> with each line table row, so that it can provide accurate pc -> line
> number mappings for optimized code, while still ignoring !is_stmt
> lines when setting breakpoints and single-stepping. The compiler will
> eventually need to start using the is_stmt flag when scheduling causes
> the line number to hop around, so that we don't stop multiple times on
> one line of code.
Agreed completely.
>
> Tested on x86_64. No new regressions with a compiler that does not set
> is_stmt == 0. OK for trunk?
>
> -cary
>
>
> * dwarf2read.c (dwarf_decode_lines): Ignore rows where is_stmt is 0.
> Set basic_block to 0 after a special opcode.
OK.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2009-06-23 18:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 18:39 Cary Coutant
2009-06-23 18:36 ` Cary Coutant
2009-06-23 18:49 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090623184858.GB3179@caradoc.them.org \
--to=drow@false.org \
--cc=ccoutant@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox