From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 624 invoked by alias); 23 Jun 2009 18:49:11 -0000 Received: (qmail 599 invoked by uid 22791); 23 Jun 2009 18:49:08 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Jun 2009 18:49:00 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 0D43F1018C; Tue, 23 Jun 2009 18:48:59 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id E9E6810148; Tue, 23 Jun 2009 18:48:58 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1MJB3C-0000vG-4X; Tue, 23 Jun 2009 14:48:58 -0400 Date: Tue, 23 Jun 2009 18:49:00 -0000 From: Daniel Jacobowitz To: Cary Coutant Cc: gdb-patches@sourceware.org Subject: Re: DWARF is_stmt flag (revisited) Message-ID: <20090623184858.GB3179@caradoc.them.org> Mail-Followup-To: Cary Coutant , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00633.txt.bz2 On Tue, Jun 16, 2009 at 11:39:05AM -0700, Cary Coutant wrote: > Longer term, I think that gdb will need to record the is_stmt flag > with each line table row, so that it can provide accurate pc -> line > number mappings for optimized code, while still ignoring !is_stmt > lines when setting breakpoints and single-stepping. The compiler will > eventually need to start using the is_stmt flag when scheduling causes > the line number to hop around, so that we don't stop multiple times on > one line of code. Agreed completely. > > Tested on x86_64. No new regressions with a compiler that does not set > is_stmt == 0. OK for trunk? > > -cary > > > * dwarf2read.c (dwarf_decode_lines): Ignore rows where is_stmt is 0. > Set basic_block to 0 after a special opcode. OK. -- Daniel Jacobowitz CodeSourcery