Re: [patch] Accelerate blocks sorting

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Mon, 22 Jun 2009 20:14:34 +0200, Michael Snyder wrote:
> Jan Kratochvil wrote:
>> GDB has been reported as hanging on crashed webkit.
>> https://bugzilla.redhat.com/show_bug.cgi?id=507267
>>
>> Time of (using webkitgtk-debuginfo-1.1.8-1.fc11.x86_64)
>> 	gdb -nx -ex 'info line *0x350080' ~/t/libwebkit-1.0.so.2.6.0.debug </dev/null
>>
>> the patch reduces from 40.1s to 4.6s.  (0x350080 is in a CU of 0x8d6ed bytes.)


> Is it actually hanging?  Or is it just taking a long time?
[...]
> but I'm a little confused about the problem being fixed.

I do not know, provided updated GDB to the bugreporter, he may respond.

This patch may be completely unrelated to the bugreport.  Nonetheless it can
be proven by my testcase it improves the performance in specific cases a lot.

(I believe it should make this libwebkit case acceptably slow - as GDB
currently is already slow while reading debug info in general.)


> The patch looks ok at first glance,

Thanks for the review but not sure if it was a check-in approval.


Thanks,
Jan