From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5042 invoked by alias); 22 Jun 2009 18:26:33 -0000 Received: (qmail 5032 invoked by uid 22791); 22 Jun 2009 18:26:33 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 22 Jun 2009 18:26:23 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5MIQLsD013136 for ; Mon, 22 Jun 2009 14:26:22 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n5MIQLBI006125 for ; Mon, 22 Jun 2009 14:26:21 -0400 Received: from host0.dyn.jankratochvil.net (sebastian-int.corp.redhat.com [172.16.52.221]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n5MIQKqG030838 for ; Mon, 22 Jun 2009 14:26:20 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id n5MIQJss031159; Mon, 22 Jun 2009 20:26:19 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id n5MIQIwW031158; Mon, 22 Jun 2009 20:26:18 +0200 Date: Mon, 22 Jun 2009 18:26:00 -0000 From: Jan Kratochvil To: Michael Snyder Cc: "gdb-patches@sourceware.org" Subject: Re: [patch] Accelerate blocks sorting Message-ID: <20090622182617.GA30367@host0.dyn.jankratochvil.net> References: <20090622173856.GA6649@host0.dyn.jankratochvil.net> <4A3FCA0A.3020403@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A3FCA0A.3020403@vmware.com> User-Agent: Mutt/1.5.19 (2009-01-05) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00572.txt.bz2 On Mon, 22 Jun 2009 20:14:34 +0200, Michael Snyder wrote: > Jan Kratochvil wrote: >> GDB has been reported as hanging on crashed webkit. >> https://bugzilla.redhat.com/show_bug.cgi?id=507267 >> >> Time of (using webkitgtk-debuginfo-1.1.8-1.fc11.x86_64) >> gdb -nx -ex 'info line *0x350080' ~/t/libwebkit-1.0.so.2.6.0.debug > >> the patch reduces from 40.1s to 4.6s. (0x350080 is in a CU of 0x8d6ed bytes.) > Is it actually hanging? Or is it just taking a long time? [...] > but I'm a little confused about the problem being fixed. I do not know, provided updated GDB to the bugreporter, he may respond. This patch may be completely unrelated to the bugreport. Nonetheless it can be proven by my testcase it improves the performance in specific cases a lot. (I believe it should make this libwebkit case acceptably slow - as GDB currently is already slow while reading debug info in general.) > The patch looks ok at first glance, Thanks for the review but not sure if it was a check-in approval. Thanks, Jan