Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* PATCH: PR server/10306: gdb 6.8.50.20090622-cvs failed to build on  Linux/ia64
@ 2009-06-22 14:48 H.J. Lu
  2009-06-22 15:20 ` Pedro Alves
  0 siblings, 1 reply; 2+ messages in thread
From: H.J. Lu @ 2009-06-22 14:48 UTC (permalink / raw)
  To: GDB

On RHEL4/ia64, gdb 6.8.50.20090622-cvs failed to build:

/net/gnu-6/export/gnu/src/gdb/gdb/gdb/remote.c: In function `getpkt_or_notif_sane_1':
/net/gnu-6/export/gnu/src/gdb/gdb/gdb/remote.c:6383: warning: 'val'
might be used uninitialized in this function

This patch works for me. No regressions on Linux/ia32 and Linux/x86-64.
OK to install?

Thanks.


H.J.
---
2009-06-22  H.J. Lu  <hongjiu.lu@intel.com>

	PR server/10306
	* remote.c (getpkt_or_notif_sane_1): Initialize val to 0.

--- gdb/remote.c.foo	2009-06-22 06:02:49.000000000 -0700
+++ gdb/remote.c	2009-06-22 07:32:13.000000000 -0700
@@ -6380,7 +6380,7 @@ getpkt_or_notif_sane_1 (char **buf, long
   int c;
   int tries;
   int timeout;
-  int val;
+  int val = -1;
 
   /* We're reading a new response.  Make sure we don't look at a
      previously cached response.  */


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: PATCH: PR server/10306: gdb 6.8.50.20090622-cvs failed to build on  Linux/ia64
  2009-06-22 14:48 PATCH: PR server/10306: gdb 6.8.50.20090622-cvs failed to build on Linux/ia64 H.J. Lu
@ 2009-06-22 15:20 ` Pedro Alves
  0 siblings, 0 replies; 2+ messages in thread
From: Pedro Alves @ 2009-06-22 15:20 UTC (permalink / raw)
  To: gdb-patches, H.J. Lu

On Monday 22 June 2009 15:48:11, H.J. Lu wrote:

> 2009-06-22  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	PR server/10306
> 	* remote.c (getpkt_or_notif_sane_1): Initialize val to 0.
                                                               ^ -1, actually.

Ok.

-- 
Pedro Alves


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-06-22 15:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-22 14:48 PATCH: PR server/10306: gdb 6.8.50.20090622-cvs failed to build on Linux/ia64 H.J. Lu
2009-06-22 15:20 ` Pedro Alves

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox