From: DJ Delorie <dj@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PING][RFA-v2] Fix troubles with watchpoints in DJGPP
Date: Wed, 17 Jun 2009 22:44:00 -0000 [thread overview]
Message-ID: <200906172244.n5HMiQhi024721@greed.delorie.com> (raw)
In-Reply-To: <20090617123152.GA7582@adacore.com> (message from Joel Brobecker on Wed, 17 Jun 2009 05:31:53 -0700)
> > /* If the user sets watchpoints before execution having started,
> > then she gets software watchpoints, because GDB can't know which
> > target will end up being pushed, or if it supports hardware
> > watchpoints or not. breakpoint_re_set takes care of promoting
> > watchpoints to hardware watchpoints if possible, however, if this
> > new inferior doesn't load shared libraries or we don't pull in
> > symbols from any other source on this target/arch,
> > breakpoint_re_set is never called. Call it now so that software
> > watchpoints get a chance to be promoted to hardware watchpoints
> > if the now pushed target supports hardware watchpoints. */
> > breakpoint_re_set ();
>
> Best Comment Of The Year Award! I love comments like these.
Agreed. I tell people I'm mentoring, comments should explain *why*,
the code already says *what*. This is an excellent example of that.
prev parent reply other threads:[~2009-06-17 22:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 7:49 [RFA] " Pierre Muller (IMAP)
2009-05-27 19:25 ` Eli Zaretskii
2009-05-27 20:53 ` Pierre Muller
2009-05-28 8:21 ` Eli Zaretskii
2009-05-28 9:31 ` Pierre Muller
2009-05-28 13:27 ` Eli Zaretskii
2009-05-27 23:30 ` Pedro Alves
2009-05-28 8:08 ` Eli Zaretskii
2009-06-08 16:16 ` [RFA-v2] " Pierre Muller
2009-06-16 22:38 ` [PING][RFA-v2] " Pierre Muller
2009-06-16 22:59 ` Pedro Alves
2009-06-16 23:20 ` Pierre Muller
2009-06-16 23:46 ` Pedro Alves
2009-06-16 23:54 ` Pierre Muller
2009-06-17 0:05 ` Pedro Alves
2009-06-17 6:19 ` Pierre Muller
2009-06-17 12:32 ` Joel Brobecker
2009-06-17 22:44 ` DJ Delorie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906172244.n5HMiQhi024721@greed.delorie.com \
--to=dj@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox