From: Pedro Alves <pedro@codesourcery.com>
To: "Pierre Muller" <muller@ics.u-strasbg.fr>
Cc: gdb-patches@sourceware.org, "'Eli Zaretskii'" <eliz@gnu.org>
Subject: Re: [PING][RFA-v2] Fix troubles with watchpoints in DJGPP
Date: Tue, 16 Jun 2009 22:59:00 -0000 [thread overview]
Message-ID: <200906162359.43456.pedro@codesourcery.com> (raw)
In-Reply-To: <000001c9eed3$0e883f10$2b98bd30$@u-strasbg.fr>
On Tuesday 16 June 2009 23:37:38, Pierre Muller wrote:
>
> No one reacted to this second version of my patch...
My reaction was that the patch looked OK,
but please could you expand the comment some more to
explain a bit better why we need this:
+ /* Call breakpoint_re_set to update watchpoints types. */
+ breakpoint_re_set ();
This almost looks like:
+ /* Increment variable by one. */
+ i++;
;-)
breakpoint_re_set is very likely to be something we
will be wanting to split further, make smarter and/or
eliminate, so having its non-obvious uses nicely described
is a good thing, IMO.
> I still have other hardware watchpoint related problems
> that need to be discussed, but this one is really a small patch,
> no ?
--
Pedro Alves
next prev parent reply other threads:[~2009-06-16 22:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 7:49 [RFA] " Pierre Muller (IMAP)
2009-05-27 19:25 ` Eli Zaretskii
2009-05-27 20:53 ` Pierre Muller
2009-05-28 8:21 ` Eli Zaretskii
2009-05-28 9:31 ` Pierre Muller
2009-05-28 13:27 ` Eli Zaretskii
2009-05-27 23:30 ` Pedro Alves
2009-05-28 8:08 ` Eli Zaretskii
2009-06-08 16:16 ` [RFA-v2] " Pierre Muller
2009-06-16 22:38 ` [PING][RFA-v2] " Pierre Muller
2009-06-16 22:59 ` Pedro Alves [this message]
2009-06-16 23:20 ` Pierre Muller
2009-06-16 23:46 ` Pedro Alves
2009-06-16 23:54 ` Pierre Muller
2009-06-17 0:05 ` Pedro Alves
2009-06-17 6:19 ` Pierre Muller
2009-06-17 12:32 ` Joel Brobecker
2009-06-17 22:44 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906162359.43456.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=muller@ics.u-strasbg.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox