Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Michael Snyder <msnyder@vmware.com>,  vladimir@codesourcery.com
Subject: Re: [PATCH] fix break-always test
Date: Fri, 29 May 2009 23:56:00 -0000	[thread overview]
Message-ID: <200905300056.43216.pedro@codesourcery.com> (raw)
In-Reply-To: <4A2072C1.9000409@vmware.com>

On Saturday 30 May 2009 00:41:53, Michael Snyder wrote:
> "set breakpoint always" does not accept "1", it wants "on".
> 

 (gdb) set breakpoint always-inserted 1
 Undefined item: "1".
 (gdb) PASS: gdb.base/break-always.exp: set breakpoint always-inserted 1

Outch, this used to work, until set breakpoint always-inserted
was made into a three-state.  Yikes, this has been broken for months.
My fault, as usual.  :-)

> 2009-05-29  Michael Snyder  <msnyder@vmware.com>
>
>        * gdb.base/break-always.exp: Change "1" to "on".

This is certainly OK.

It would be a nice improvent to make the test confirm that
the mode is in effect, perhaps by just reading back the setting
with "show breakpoint always-inserted".

-- 
Pedro Alves


  reply	other threads:[~2009-05-29 23:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-29 23:44 Michael Snyder
2009-05-29 23:56 ` Pedro Alves [this message]
2009-06-01 19:24   ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905300056.43216.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox