From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-64078-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9912 invoked by alias); 29 May 2009 23:56:34 -0000
Received: (qmail 9904 invoked by uid 22791); 29 May 2009 23:56:33 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 29 May 2009 23:56:28 +0000
Received: (qmail 18906 invoked from network); 29 May 2009 23:56:26 -0000
Received: from unknown (HELO orlando.local) (pedro@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 29 May 2009 23:56:26 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] fix break-always test
Date: Fri, 29 May 2009 23:56:00 -0000
User-Agent: KMail/1.9.10
Cc: Michael Snyder <msnyder@vmware.com>,  vladimir@codesourcery.com
References: <4A2072C1.9000409@vmware.com>
In-Reply-To: <4A2072C1.9000409@vmware.com>
MIME-Version: 1.0
Content-Type: text/plain;   charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200905300056.43216.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-05/txt/msg00641.txt.bz2

On Saturday 30 May 2009 00:41:53, Michael Snyder wrote:
> "set breakpoint always" does not accept "1", it wants "on".
> 

 (gdb) set breakpoint always-inserted 1
 Undefined item: "1".
 (gdb) PASS: gdb.base/break-always.exp: set breakpoint always-inserted 1

Outch, this used to work, until set breakpoint always-inserted
was made into a three-state.  Yikes, this has been broken for months.
My fault, as usual.  :-)

> 2009-05-29  Michael Snyder  <msnyder@vmware.com>
>
>        * gdb.base/break-always.exp: Change "1" to "on".

This is certainly OK.

It would be a nice improvent to make the test confirm that
the mode is in effect, perhaps by just reading back the setting
with "show breakpoint always-inserted".

-- 
Pedro Alves