From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: brobecker@adacore.com (Joel Brobecker)
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Ada simplification: ada_coerce_to_simple_array_type
Date: Mon, 18 May 2009 13:51:00 -0000 [thread overview]
Message-ID: <200905181350.n4IDoUPm003693@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <20090515140701.GK7292@adacore.com> from "Joel Brobecker" at May 15, 2009 04:07:01 PM
Joel Brobecker wrote:
> > * ada-lang.c (ada_coerce_to_simple_array_type): Reimplement to
> > avoid creating a dummy value.
>
> I like this change. On the one hand, it's a slight duplication, but this
> is a relatively standard idiom, so it's OK. When I'm done reconciling
> the sources with AdaCore's, it'll be easier for me to overhaul the ada-*
> sources. Thanks for this patch.
Thanks for the review! I've checked the patch in now.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2009-05-18 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 11:36 Ulrich Weigand
2009-05-15 14:07 ` Joel Brobecker
2009-05-18 13:51 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905181350.n4IDoUPm003693@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox