From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23834 invoked by alias); 18 May 2009 13:51:43 -0000 Received: (qmail 23823 invoked by uid 22791); 18 May 2009 13:51:42 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 18 May 2009 13:51:38 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.14.3/8.13.8) with ESMTP id n4IDoYZi332416 for ; Mon, 18 May 2009 13:50:34 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n4IDoVX93891338 for ; Mon, 18 May 2009 15:50:31 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n4IDoVQD003714 for ; Mon, 18 May 2009 15:50:31 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n4IDoUPm003693; Mon, 18 May 2009 15:50:30 +0200 Message-Id: <200905181350.n4IDoUPm003693@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 18 May 2009 15:50:29 +0200 Subject: Re: [rfc] Ada simplification: ada_coerce_to_simple_array_type To: brobecker@adacore.com (Joel Brobecker) Date: Mon, 18 May 2009 13:51:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20090515140701.GK7292@adacore.com> from "Joel Brobecker" at May 15, 2009 04:07:01 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00359.txt.bz2 Joel Brobecker wrote: > > * ada-lang.c (ada_coerce_to_simple_array_type): Reimplement to > > avoid creating a dummy value. > > I like this change. On the one hand, it's a slight duplication, but this > is a relatively standard idiom, so it's OK. When I'm done reconciling > the sources with AdaCore's, it'll be easier for me to overhaul the ada-* > sources. Thanks for this patch. Thanks for the review! I've checked the patch in now. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com