From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: mark.kettenis@xs4all.nl (Mark Kettenis)
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Remove deprecated_extract/store_floating
Date: Mon, 18 May 2009 13:44:00 -0000 [thread overview]
Message-ID: <200905181344.n4IDigfZ027703@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <200905141204.n4EC4XDb003182@brahms.sibelius.xs4all.nl> from "Mark Kettenis" at May 14, 2009 02:04:33 PM
Mark Kettenis wrote:
> > Date: Thu, 14 May 2009 13:32:57 +0200 (CEST)
> > From: "Ulrich Weigand" <uweigand@de.ibm.com>
> >
> > Hello,
> >
> > this patch removes the old deprecated_extract_floating and
> > deprecated_store_floating routines. There was one remaining use
> > in sh64-tdep.c, which seems an oversight and is trivially replacable
> > by extract_typed_floating.
> >
> > In addition, the patch inlines the extract_floating_by_length and
> > store_floating_by_length into their callers, which leads to some
> > simplification of the doublest.c code.
> >
> > Tested on powerpc64-linux with no regression.
> > I'm planning on committing this patch in a couple of days.
>
> Looks good to me.
Thanks for the review!
I've checked the patch in now.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2009-05-18 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 11:33 Ulrich Weigand
2009-05-14 12:04 ` Mark Kettenis
2009-05-18 13:44 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905181344.n4IDigfZ027703@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox