From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16304 invoked by alias); 18 May 2009 13:44:54 -0000 Received: (qmail 16261 invoked by uid 22791); 18 May 2009 13:44:52 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtagate2.de.ibm.com (HELO mtagate2.de.ibm.com) (195.212.17.162) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 18 May 2009 13:44:47 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate2.de.ibm.com (8.13.1/8.13.1) with ESMTP id n4IDihmI017508 for ; Mon, 18 May 2009 13:44:43 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n4IDihSA3571914 for ; Mon, 18 May 2009 15:44:43 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n4IDihBQ027722 for ; Mon, 18 May 2009 15:44:43 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n4IDigfZ027703; Mon, 18 May 2009 15:44:42 +0200 Message-Id: <200905181344.n4IDigfZ027703@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 18 May 2009 15:44:42 +0200 Subject: Re: [rfc] Remove deprecated_extract/store_floating To: mark.kettenis@xs4all.nl (Mark Kettenis) Date: Mon, 18 May 2009 13:44:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <200905141204.n4EC4XDb003182@brahms.sibelius.xs4all.nl> from "Mark Kettenis" at May 14, 2009 02:04:33 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00356.txt.bz2 Mark Kettenis wrote: > > Date: Thu, 14 May 2009 13:32:57 +0200 (CEST) > > From: "Ulrich Weigand" > > > > Hello, > > > > this patch removes the old deprecated_extract_floating and > > deprecated_store_floating routines. There was one remaining use > > in sh64-tdep.c, which seems an oversight and is trivially replacable > > by extract_typed_floating. > > > > In addition, the patch inlines the extract_floating_by_length and > > store_floating_by_length into their callers, which leads to some > > simplification of the doublest.c code. > > > > Tested on powerpc64-linux with no regression. > > I'm planning on committing this patch in a couple of days. > > Looks good to me. Thanks for the review! I've checked the patch in now. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com