From: Joel Brobecker <brobecker@adacore.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Ada simplification: ada_find_any_type
Date: Fri, 15 May 2009 15:14:00 -0000 [thread overview]
Message-ID: <20090515151429.GN7292@adacore.com> (raw)
In-Reply-To: <200905141138.n4EBcT3v005484@d12av02.megacenter.de.ibm.com>
>
> * ada-lang.c (ada_find_any_type): Move check for primitive types ...
> (to_fixed_range_type): ... to here.
Looks OK as well.
Would you mind extending the description of ada_find_any_type to
say that it does not search the primitive types? Otherwise, I'm afraid
that we might come across a situation one day where we want to search
the primitive types after a call to that function, and add it back
in that function because we weren't paying attention...
Thanks a lot,
--
Joel
next prev parent reply other threads:[~2009-05-15 15:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 11:38 Ulrich Weigand
2009-05-15 15:14 ` Joel Brobecker [this message]
2009-05-18 14:01 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090515151429.GN7292@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox