From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6149 invoked by alias); 15 May 2009 15:14:46 -0000 Received: (qmail 6138 invoked by uid 22791); 15 May 2009 15:14:45 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 May 2009 15:14:33 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8E39D2BABE0; Fri, 15 May 2009 11:14:31 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id OQ836MfHEguZ; Fri, 15 May 2009 11:14:31 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5A23E2BABDF; Fri, 15 May 2009 11:14:31 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 62A79F5962; Fri, 15 May 2009 17:14:29 +0200 (CEST) Date: Fri, 15 May 2009 15:14:00 -0000 From: Joel Brobecker To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [rfc] Ada simplification: ada_find_any_type Message-ID: <20090515151429.GN7292@adacore.com> References: <200905141138.n4EBcT3v005484@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200905141138.n4EBcT3v005484@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00326.txt.bz2 > > * ada-lang.c (ada_find_any_type): Move check for primitive types ... > (to_fixed_range_type): ... to here. Looks OK as well. Would you mind extending the description of ada_find_any_type to say that it does not search the primitive types? Otherwise, I'm afraid that we might come across a situation one day where we want to search the primitive types after a call to that function, and add it back in that function because we weren't paying attention... Thanks a lot, -- Joel