From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: pedro@codesourcery.com
Cc: gdb-patches@sourceware.org, teawater@gmail.com
Subject: Re: [RFA Precord] Disable process record in amd64
Date: Wed, 13 May 2009 10:24:00 -0000 [thread overview]
Message-ID: <200905131022.n4DAMWiD000990@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <200905131118.02697.pedro@codesourcery.com> (message from Pedro Alves on Wed, 13 May 2009 11:18:02 +0100)
> From: Pedro Alves <pedro@codesourcery.com>
> Date: Wed, 13 May 2009 11:18:02 +0100
>
> On Wednesday 13 May 2009 09:07:03, Hui Zhu wrote:
> > Hi,
> >
> > The i386 process record can't work together with amd64 now. So I make
> > a patch to disable it in amd64.
>
> It would be better to move the `set_gdbarch_process_record (gdbarch, i386_process_record)'
> call to tdep files where precord will actually work --- in this
> case, i386-linux-tdep.c --- instead of having i386-tdep.c assume
> precord support. We've done the exact same thing for displaced
> stepping.
I agree with Pedro here.
next prev parent reply other threads:[~2009-05-13 10:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-13 8:07 Hui Zhu
2009-05-13 10:18 ` Pedro Alves
2009-05-13 10:24 ` Mark Kettenis [this message]
2009-05-13 16:31 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905131022.n4DAMWiD000990@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox