From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 981 invoked by alias); 13 May 2009 10:24:35 -0000 Received: (qmail 970 invoked by uid 22791); 13 May 2009 10:24:34 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 May 2009 10:24:22 +0000 Received: from brahms.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by brahms.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id n4DAMWGT029332; Wed, 13 May 2009 12:22:32 +0200 (CEST) Received: (from kettenis@localhost) by brahms.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id n4DAMWiD000990; Wed, 13 May 2009 12:22:32 +0200 (CEST) Date: Wed, 13 May 2009 10:24:00 -0000 Message-Id: <200905131022.n4DAMWiD000990@brahms.sibelius.xs4all.nl> From: Mark Kettenis To: pedro@codesourcery.com CC: gdb-patches@sourceware.org, teawater@gmail.com In-reply-to: <200905131118.02697.pedro@codesourcery.com> (message from Pedro Alves on Wed, 13 May 2009 11:18:02 +0100) Subject: Re: [RFA Precord] Disable process record in amd64 References: <200905131118.02697.pedro@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00268.txt.bz2 > From: Pedro Alves > Date: Wed, 13 May 2009 11:18:02 +0100 > > On Wednesday 13 May 2009 09:07:03, Hui Zhu wrote: > > Hi, > > > > The i386 process record can't work together with amd64 now. So I make > > a patch to disable it in amd64. > > It would be better to move the `set_gdbarch_process_record (gdbarch, i386_process_record)' > call to tdep files where precord will actually work --- in this > case, i386-linux-tdep.c --- instead of having i386-tdep.c assume > precord support. We've done the exact same thing for displaced > stepping. I agree with Pedro here.