From: Joel Brobecker <brobecker@adacore.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: gdb-patches@sourceware.org, Tom Tromey <tromey@redhat.com>
Subject: Re: [patch] Eliminate quadratic slow-down on number of soilibs (part 2).
Date: Tue, 12 May 2009 09:11:00 -0000 [thread overview]
Message-ID: <20090512091057.GE7584@adacore.com> (raw)
In-Reply-To: <20090501221639.4FF8A19C4E1@localhost>
> 2009-05-01 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> * objc-lang.c (objc_objfile_data): New variable.
> (find_methods): Skip objfiles without Obj-C methods.
> (_initialize_objc_lang): New function.
Looks good to me. If I may, would you mind adding a comment explaining
*why* you count the number of symbols? I think it can help understanding
the added code a little bit faster...
/* If we haven't done so for this objfile yet, count the number
of objc methods that this objfile defines and save it as a private
objfile data. That way, if have already determined that this
objfile provides no objc methods, we can skip it entirely. */
I wonder how well support for ObjC works. It looks like this file hasn't
really be worked on for a long time... Did you have an objc compiler in
your path when you did the testing, by any chance?
--
Joel
next prev parent reply other threads:[~2009-05-12 9:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-01 22:17 Paul Pluzhnikov
2009-05-12 9:11 ` Joel Brobecker [this message]
2009-05-18 21:27 ` Tom Tromey
2009-05-18 22:15 ` Paul Pluzhnikov
2009-05-18 22:48 ` Tom Tromey
2009-05-18 22:58 ` Paul Pluzhnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090512091057.GE7584@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=ppluzhnikov@google.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox