From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19064 invoked by alias); 12 May 2009 09:11:08 -0000 Received: (qmail 19056 invoked by uid 22791); 12 May 2009 09:11:07 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 May 2009 09:11:01 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AE2612BAAFD; Tue, 12 May 2009 05:10:59 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Qlb1ilasKdAZ; Tue, 12 May 2009 05:10:59 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 70B4E2BAAB3; Tue, 12 May 2009 05:10:59 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id CF83DF5905; Tue, 12 May 2009 11:10:57 +0200 (CEST) Date: Tue, 12 May 2009 09:11:00 -0000 From: Joel Brobecker To: Paul Pluzhnikov Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [patch] Eliminate quadratic slow-down on number of soilibs (part 2). Message-ID: <20090512091057.GE7584@adacore.com> References: <20090501221639.4FF8A19C4E1@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090501221639.4FF8A19C4E1@localhost> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00240.txt.bz2 > 2009-05-01 Paul Pluzhnikov > > * objc-lang.c (objc_objfile_data): New variable. > (find_methods): Skip objfiles without Obj-C methods. > (_initialize_objc_lang): New function. Looks good to me. If I may, would you mind adding a comment explaining *why* you count the number of symbols? I think it can help understanding the added code a little bit faster... /* If we haven't done so for this objfile yet, count the number of objc methods that this objfile defines and save it as a private objfile data. That way, if have already determined that this objfile provides no objc methods, we can skip it entirely. */ I wonder how well support for ObjC works. It looks like this file hasn't really be worked on for a long time... Did you have an objc compiler in your path when you did the testing, by any chance? -- Joel