From: Joel Brobecker <brobecker@adacore.com>
To: Pierre Muller <muller@ics.u-strasbg.fr>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Unify target header macros
Date: Mon, 11 May 2009 09:17:00 -0000 [thread overview]
Message-ID: <20090511091733.GB14773@adacore.com> (raw)
In-Reply-To: <005a01c9d18a$77d3c8b0$677b5a10$@u-strasbg.fr>
> In particular, I suspect that some of the comments
> that are changed by that patch are obsolete...
It would be nice to revisit these comments in the future, but in the
meantime, it's sufficient to keep their content in sync with the code.
So this is OK for now.
> 2009-05-10 Pierre Muller <muller.u-strasbg.fr>
>
> Unify target macros.
>
> * target.h (STOPPED_BY_WATCHPOINT): Delete, replaced by ...
> (target_stoppped_by_watchpoint): New macro.
> (HAVE_STEPPABLE_WATCHPOINT): Delete, replaced by ...
> (target_have_steppable_watchpoint): New macro.
> (HAVE_CONTINUABLE_WATCHPOINT): Delete, replace by ...
> (target_have_continuable_watchpoint): New macro.
> (TARGET_CAN_USE_HARDWARE_WATCHPOINT):Delete, replaced by ...
> (target_can_use_hardware_watchpoint): New macro.
> (TARGET_REGION_OK_FOR_HW_WATCHPOINT):Delete, replaced by ...
> (target_region_ok_for_hw_watchpoint): New macro.
>
> * breakpoint.c (update_watchpoint): Use new macros.
> (bpstat_alloc): Likewise.
> (create_breakpoint): Likewise.
> (watch_command_1): Likewise.
> (can_use_hardware_watchpoint): Likewise.
> (do_enable_breakpoint): Likewise.
> * infrun.c (handle_inferior_event): Adapt to new macros.
> * mips-tdep.c (mips_gdbarch_init): Update comments.
> * procfs.c (procfs_set_watchpoint): Update comment.
> (procfs_insert_watchpoint): Adapt to new macros.
> * remote-m32r-sdi.c (m32r_stop):
> * remote-mips.c (mips_remove_breakpoint):
> * target.c (debug_to_region_ok_for_hw_watchpoint): Update to new
> macros.
> (debug_to_stopped_by_watchpoint): Likewise.
Looks good to me.
Thanks for doing this.
--
Joel
next prev parent reply other threads:[~2009-05-11 9:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-10 16:15 Pierre Muller
2009-05-11 9:17 ` Joel Brobecker [this message]
2009-05-11 11:17 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090511091733.GB14773@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=muller@ics.u-strasbg.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox