From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3053 invoked by alias); 11 May 2009 09:17:42 -0000 Received: (qmail 2744 invoked by uid 22791); 11 May 2009 09:17:41 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 May 2009 09:17:37 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6FFFB2BAB81; Mon, 11 May 2009 05:17:35 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id gcfjk-hAgAZe; Mon, 11 May 2009 05:17:35 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 402D32BAB7D; Mon, 11 May 2009 05:17:35 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 9B2E3F5901; Mon, 11 May 2009 02:17:33 -0700 (PDT) Date: Mon, 11 May 2009 09:17:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Unify target header macros Message-ID: <20090511091733.GB14773@adacore.com> References: <005a01c9d18a$77d3c8b0$677b5a10$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <005a01c9d18a$77d3c8b0$677b5a10$@u-strasbg.fr> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00204.txt.bz2 > In particular, I suspect that some of the comments > that are changed by that patch are obsolete... It would be nice to revisit these comments in the future, but in the meantime, it's sufficient to keep their content in sync with the code. So this is OK for now. > 2009-05-10 Pierre Muller > > Unify target macros. > > * target.h (STOPPED_BY_WATCHPOINT): Delete, replaced by ... > (target_stoppped_by_watchpoint): New macro. > (HAVE_STEPPABLE_WATCHPOINT): Delete, replaced by ... > (target_have_steppable_watchpoint): New macro. > (HAVE_CONTINUABLE_WATCHPOINT): Delete, replace by ... > (target_have_continuable_watchpoint): New macro. > (TARGET_CAN_USE_HARDWARE_WATCHPOINT):Delete, replaced by ... > (target_can_use_hardware_watchpoint): New macro. > (TARGET_REGION_OK_FOR_HW_WATCHPOINT):Delete, replaced by ... > (target_region_ok_for_hw_watchpoint): New macro. > > * breakpoint.c (update_watchpoint): Use new macros. > (bpstat_alloc): Likewise. > (create_breakpoint): Likewise. > (watch_command_1): Likewise. > (can_use_hardware_watchpoint): Likewise. > (do_enable_breakpoint): Likewise. > * infrun.c (handle_inferior_event): Adapt to new macros. > * mips-tdep.c (mips_gdbarch_init): Update comments. > * procfs.c (procfs_set_watchpoint): Update comment. > (procfs_insert_watchpoint): Adapt to new macros. > * remote-m32r-sdi.c (m32r_stop): > * remote-mips.c (mips_remove_breakpoint): > * target.c (debug_to_region_ok_for_hw_watchpoint): Update to new > macros. > (debug_to_stopped_by_watchpoint): Likewise. Looks good to me. Thanks for doing this. -- Joel