Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: "Ulrich Weigand" <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org,  Daniel Jacobowitz <drow@false.org>
Subject: Re: [rfc] Do not call read_pc in startup_inferior
Date: Tue, 05 May 2009 21:43:00 -0000	[thread overview]
Message-ID: <200905052244.19929.pedro@codesourcery.com> (raw)
In-Reply-To: <200905041738.n44Hcx78013893@d12av02.megacenter.de.ibm.com>

On Monday 04 May 2009 18:38:59, Ulrich Weigand wrote:
> Makes sense.  This means we'd have to remember the "thread we last
> stopped at" so we can show its stop_pc.  I don't think we actually
> have this information right now?

We have `get_last_target_status', which infcmd.c:program_info
already uses.

> Indeed.  That's another odd corner that I've never quite understood:
> at the point where we look at breakpoints, the "bpstat" structure is
> already able to represent that multiple causes of actions have occurred
> at the same time.  But this detailed status is then reduced via bpstat_what
> to a single action code ...   Maybe handle_inferior_event should
> really make full use of all the information present in the bpstat.

Yeah...  I think that the basic idea was that most of the stop
actions in the bpstat structure are mutually exclusive.  E.g.,
set-longjmp-resume, step-resume, longjmp-resume, single-stepping,
user breakpoints.  If you're handling one of these, all the other
actions that could be associated with one of the other
simultaneous breakpoints should be cancelled, so in a sense, the 
ordering and reducing make some sense.  This breaks if the actions
aren't really mutually exclusive, like in the shlib event case.
Probably, something like eliminating BPSTAT_WHAT_CHECK_SHLIBS and
adding a check_shlibs boolean field to `struct bpstat_what'
isn't too far from fixing this case.

-- 
Pedro Alves


  reply	other threads:[~2009-05-05 21:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-28 16:37 Ulrich Weigand
2009-04-28 19:28 ` Daniel Jacobowitz
2009-04-29 12:33   ` Ulrich Weigand
2009-04-29 13:07     ` Pedro Alves
2009-04-30 14:27       ` Ulrich Weigand
2009-04-30 15:55         ` Pedro Alves
2009-05-04 17:40           ` Ulrich Weigand
2009-05-05 21:43             ` Pedro Alves [this message]
2009-05-05 13:28 ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905052244.19929.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox