Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Do not call read_pc in startup_inferior
Date: Tue, 28 Apr 2009 19:28:00 -0000	[thread overview]
Message-ID: <20090428192826.GA31724@caradoc.them.org> (raw)
In-Reply-To: <200904281637.n3SGbClg009383@d12av02.megacenter.de.ibm.com>

On Tue, Apr 28, 2009 at 06:37:12PM +0200, Ulrich Weigand wrote:
> Hello,
> 
> a while ago, I committed a patch to avoid calling wait_for_inferior
> in startup_inferior, so as to avoid accessing inferior register state
> at a time where the target's actual register layout has not yet been
> determined (via target_find_description).
> 
> However, startup_inferior still contains a read_pc call to retrieve
> the initial value of stop_pc -- this of course runs into the same
> problem.
> 
> The patch below removes the read_pc call from startup_inferior, and
> instead determines the initial stop_pc value in post_create_inferior,
> after the register layout has been finalized.

You're moving the call from a native "run" only routine, to an
all-targets routine.  That made me curious so I went looking... what
relies on this setting?  Anything?

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2009-04-28 19:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-28 16:37 Ulrich Weigand
2009-04-28 19:28 ` Daniel Jacobowitz [this message]
2009-04-29 12:33   ` Ulrich Weigand
2009-04-29 13:07     ` Pedro Alves
2009-04-30 14:27       ` Ulrich Weigand
2009-04-30 15:55         ` Pedro Alves
2009-05-04 17:40           ` Ulrich Weigand
2009-05-05 21:43             ` Pedro Alves
2009-05-05 13:28 ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090428192826.GA31724@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox