From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: Can we get rid of go32_stop? (and its normal_stop call?)
Date: Fri, 01 May 2009 17:56:00 -0000 [thread overview]
Message-ID: <200905011856.33645.pedro@codesourcery.com> (raw)
In-Reply-To: <83r5z8darm.fsf@gnu.org>
On Friday 01 May 2009 17:54:21, Eli Zaretskii wrote:
> I patched my snapshot with your changes, let me run with it for some
> time and see if anything goes wrong. You can commit the changes in
> the meantime.
Thanks, that's great.
> Out of curiosity: why was normal_stop sentenced to death?
It relies on hidden global state as input parameters, e.g.,
get_last_target_status(), stopped_by_random_signal, stop_stack_dummy,
that breakpoints hadn't been removed yet, etc., so it's not exactly
correct to call it at random times. Also importantly (and that's
what I was after) not having it being called from outside of the core
of inferior control makes it easier to work on cleaning up and
refactoring bits of infrun.c.
--
Pedro Alves
next prev parent reply other threads:[~2009-05-01 17:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-01 14:14 Pedro Alves
2009-05-01 15:47 ` Eli Zaretskii
2009-05-01 16:24 ` Pedro Alves
2009-05-01 16:54 ` Eli Zaretskii
2009-05-01 17:50 ` Eli Zaretskii
2009-05-01 17:57 ` Pedro Alves
2009-05-01 17:56 ` Pedro Alves [this message]
2009-05-01 17:59 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905011856.33645.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox