From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27407 invoked by alias); 1 May 2009 17:56:42 -0000 Received: (qmail 27399 invoked by uid 22791); 1 May 2009 17:56:41 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,SARE_SUB_GETRID,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 May 2009 17:56:36 +0000 Received: (qmail 21133 invoked from network); 1 May 2009 17:56:34 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 1 May 2009 17:56:34 -0000 From: Pedro Alves To: gdb-patches@sourceware.org, Eli Zaretskii Subject: Re: Can we get rid of go32_stop? (and its normal_stop call?) Date: Fri, 01 May 2009 17:56:00 -0000 User-Agent: KMail/1.9.10 References: <200905011514.27632.pedro@codesourcery.com> <200905011724.36973.pedro@codesourcery.com> <83r5z8darm.fsf@gnu.org> In-Reply-To: <83r5z8darm.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200905011856.33645.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00037.txt.bz2 On Friday 01 May 2009 17:54:21, Eli Zaretskii wrote: > I patched my snapshot with your changes, let me run with it for some > time and see if anything goes wrong. You can commit the changes in > the meantime. Thanks, that's great. > Out of curiosity: why was normal_stop sentenced to death? It relies on hidden global state as input parameters, e.g., get_last_target_status(), stopped_by_random_signal, stop_stack_dummy, that breakpoints hadn't been removed yet, etc., so it's not exactly correct to call it at random times. Also importantly (and that's what I was after) not having it being called from outside of the core of inferior control makes it easier to work on cleaning up and refactoring bits of infrun.c. -- Pedro Alves