From: Joel Brobecker <brobecker@adacore.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: gdb-patches@sourceware.org, Frank Middleton <f.middleton@apogeect.com>
Subject: Re: [patch] Fix a buglet in elfread.c
Date: Thu, 30 Apr 2009 21:54:00 -0000 [thread overview]
Message-ID: <20090430215422.GE10734@adacore.com> (raw)
In-Reply-To: <20090430164806.7DED819C4E1@localhost>
> 2009-04-30 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> * elfread.c (elf_symtab_read): Don't assume .data and .rodata
> are present.
Looks good to me. Please go ahead and apply.
I tested this patch on sparc-solaris 2.8 with -gstabs+, since this
seems to be related to stabs. I don't think we can really test
this part of the code with a GCC compiler, but perhaps it's is
still exercised throught the loading of some of the Solaris shared
libraries. We did our best, and we had 2 pairs of eyes looking at it,
so it should be fine.
--
Joel
next prev parent reply other threads:[~2009-04-30 21:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-30 16:48 Paul Pluzhnikov
2009-04-30 17:05 ` Joel Brobecker
2009-04-30 21:54 ` Joel Brobecker [this message]
2009-04-30 22:00 ` Paul Pluzhnikov
2009-05-01 0:07 ` Frank Middleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090430215422.GE10734@adacore.com \
--to=brobecker@adacore.com \
--cc=f.middleton@apogeect.com \
--cc=gdb-patches@sourceware.org \
--cc=ppluzhnikov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox