From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14855 invoked by alias); 30 Apr 2009 21:54:38 -0000 Received: (qmail 14841 invoked by uid 22791); 30 Apr 2009 21:54:37 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 30 Apr 2009 21:54:30 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1CB6E2BACD2; Thu, 30 Apr 2009 17:54:29 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Lkwz4jIZDmRo; Thu, 30 Apr 2009 17:54:29 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D937E2BACA6; Thu, 30 Apr 2009 17:54:28 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 4883EF58FF; Thu, 30 Apr 2009 14:54:22 -0700 (PDT) Date: Thu, 30 Apr 2009 21:54:00 -0000 From: Joel Brobecker To: Paul Pluzhnikov Cc: gdb-patches@sourceware.org, Frank Middleton Subject: Re: [patch] Fix a buglet in elfread.c Message-ID: <20090430215422.GE10734@adacore.com> References: <20090430164806.7DED819C4E1@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090430164806.7DED819C4E1@localhost> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00825.txt.bz2 > 2009-04-30 Paul Pluzhnikov > > * elfread.c (elf_symtab_read): Don't assume .data and .rodata > are present. Looks good to me. Please go ahead and apply. I tested this patch on sparc-solaris 2.8 with -gstabs+, since this seems to be related to stabs. I don't think we can really test this part of the code with a GCC compiler, but perhaps it's is still exercised throught the loading of some of the Solaris shared libraries. We did our best, and we had 2 pairs of eyes looking at it, so it should be fine. -- Joel