Re: Mingw GDB build fails for M16C target

[Kevin Buettner <kevinb@redhat.com>]

On Wed, 29 Apr 2009 16:01:24 -0400
Daniel Jacobowitz <drow@false.org> wrote:

> > If you're asking why I don't simply copy sim_signal_to_target for
> > use in m32c/gdb-if.c, that's because the m32c sim doesn't use the
> > SIM_SIGfoo constants that common/sim-signal.c uses.  It does bother me
> > though that m32c_signal_to_target() uses hardcoded constants like 4,
> > 5, 10, 11, etc.  I suspect it was done this way because including the
> > correct newlib header file (without conflict with certain system
> > headers) was difficult.  That's just a guess though.
> 
> I was actually asking about sim_signal_to_host, since this was
> m32c_signal_to_host.  The sim_ version uses SIGILL, SIGTRAP, etc.

Wow, did I guess wrong.

My patch changes the name from m32c_signal_to_host() to
m32c_signal_to_target() and switches from use of host-based numbers
to target-specific numbers.

> Yes... I don't think any of the conversion routines that use host
> numbers should be there.  I'm not feeling ambitious enough to remove
> them from all sims, but perhaps you can get just m32c?

Yes, I have done this.  See above.

Kevin