From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29432 invoked by alias); 29 Apr 2009 20:27:19 -0000 Received: (qmail 29418 invoked by uid 22791); 29 Apr 2009 20:27:17 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Apr 2009 20:27:09 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n3TKR4o9025703 for ; Wed, 29 Apr 2009 16:27:04 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n3TKR3sJ014619 for ; Wed, 29 Apr 2009 16:27:04 -0400 Received: from localhost.localdomain (vpn-12-136.rdu.redhat.com [10.11.12.136]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n3TKR2om003986 for ; Wed, 29 Apr 2009 16:27:03 -0400 Date: Wed, 29 Apr 2009 20:27:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: Re: Mingw GDB build fails for M16C target Message-ID: <20090429132702.57adecb3@redhat.com> In-Reply-To: <20090429200124.GA961@caradoc.them.org> References: <82C3BC9106BCE149B63464D79D0A22FD0A68110C@sohm.kpit.com> <20090428155724.1797d332@redhat.com> <20090429023511.GA2873@caradoc.them.org> <20090429125049.054d90b8@redhat.com> <20090429200124.GA961@caradoc.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00793.txt.bz2 On Wed, 29 Apr 2009 16:01:24 -0400 Daniel Jacobowitz wrote: > > If you're asking why I don't simply copy sim_signal_to_target for > > use in m32c/gdb-if.c, that's because the m32c sim doesn't use the > > SIM_SIGfoo constants that common/sim-signal.c uses. It does bother me > > though that m32c_signal_to_target() uses hardcoded constants like 4, > > 5, 10, 11, etc. I suspect it was done this way because including the > > correct newlib header file (without conflict with certain system > > headers) was difficult. That's just a guess though. > > I was actually asking about sim_signal_to_host, since this was > m32c_signal_to_host. The sim_ version uses SIGILL, SIGTRAP, etc. Wow, did I guess wrong. My patch changes the name from m32c_signal_to_host() to m32c_signal_to_target() and switches from use of host-based numbers to target-specific numbers. > Yes... I don't think any of the conversion routines that use host > numbers should be there. I'm not feeling ambitious enough to remove > them from all sims, but perhaps you can get just m32c? Yes, I have done this. See above. Kevin