From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [patch] Better display command-line macros + doc addon [Re: [patch] doc: Document macros defined from command-line]
Date: Tue, 28 Apr 2009 20:17:00 -0000 [thread overview]
Message-ID: <20090428201659.GD31821@adacore.com> (raw)
In-Reply-To: <20090309001422.GA29150@host0.dyn.jankratochvil.net>
Jan,
Did we (ahem, I) drop the ball on you, on this patch? Sorry about that.
I don't think the change of output was particularly necessary, but I do
think it makes it easier to understand from the user's point of view:
No need to know what line 0 means in DWARF...
> gdb/
> 2009-03-09 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * macrocmd.c (info_macro_command): Print -Dname=value if LINE is zero.
> gdb/testsuite/
> 2009-03-09 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * gdb.base/macscp.exp: New `options' parameter `-DFROM_COMMANDLINE'.
> (info_macro): Remova `decimal' declaration. New variable `nonzero'.
> Replace all uses of `decimal' by `nonzero'.
> (info macro FROM_COMMANDLINE): New test.
GDB and testsuite parts look OK to me. Thanks for doing this.
> gdb/doc/
> 2009-03-09 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * gdb.texinfo (Macros): Note command-line for `info macro'. Append
> a new part on command-line defined macros.
I can't remember whether Eli approved the doco change or not, though.
--
Joel
next prev parent reply other threads:[~2009-04-28 20:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-06 20:46 [patch] doc: Document macros defined from command-line Jan Kratochvil
2009-03-07 9:16 ` Eli Zaretskii
2009-03-09 0:17 ` [patch] Better display command-line macros + doc addon [Re: [patch] doc: Document macros defined from command-line] Jan Kratochvil
2009-03-09 4:00 ` Eli Zaretskii
2009-04-28 20:17 ` Joel Brobecker [this message]
2009-04-29 7:17 ` Eli Zaretskii
2009-04-29 7:55 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090428201659.GD31821@adacore.com \
--to=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox