From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31823 invoked by alias); 28 Apr 2009 20:17:14 -0000 Received: (qmail 31815 invoked by uid 22791); 28 Apr 2009 20:17:12 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_37 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 28 Apr 2009 20:17:05 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E4EB82BAB26; Tue, 28 Apr 2009 16:17:03 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id SjgU+4l0n4o1; Tue, 28 Apr 2009 16:17:03 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A7F292BAAE1; Tue, 28 Apr 2009 16:17:03 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id ADA15F5924; Tue, 28 Apr 2009 13:16:59 -0700 (PDT) Date: Tue, 28 Apr 2009 20:17:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [patch] Better display command-line macros + doc addon [Re: [patch] doc: Document macros defined from command-line] Message-ID: <20090428201659.GD31821@adacore.com> References: <20090306204631.GA27092@host0.dyn.jankratochvil.net> <20090309001422.GA29150@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090309001422.GA29150@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00769.txt.bz2 Jan, Did we (ahem, I) drop the ball on you, on this patch? Sorry about that. I don't think the change of output was particularly necessary, but I do think it makes it easier to understand from the user's point of view: No need to know what line 0 means in DWARF... > gdb/ > 2009-03-09 Jan Kratochvil > > * macrocmd.c (info_macro_command): Print -Dname=value if LINE is zero. > gdb/testsuite/ > 2009-03-09 Jan Kratochvil > > * gdb.base/macscp.exp: New `options' parameter `-DFROM_COMMANDLINE'. > (info_macro): Remova `decimal' declaration. New variable `nonzero'. > Replace all uses of `decimal' by `nonzero'. > (info macro FROM_COMMANDLINE): New test. GDB and testsuite parts look OK to me. Thanks for doing this. > gdb/doc/ > 2009-03-09 Jan Kratochvil > > * gdb.texinfo (Macros): Note command-line for `info macro'. Append > a new part on command-line defined macros. I can't remember whether Eli approved the doco change or not, though. -- Joel