From: Joel Brobecker <brobecker@adacore.com>
To: Jerome Guitton <guitton@adacore.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [Bug symtab/8367] [RFA] performance improvement of lookup_partial_symtab
Date: Tue, 28 Apr 2009 19:57:00 -0000 [thread overview]
Message-ID: <20090428195726.GA31821@adacore.com> (raw)
In-Reply-To: <20090115094511.GB80710@adacore.com>
> > 2009-01-14 Jerome Guitton <guitton@adacore.com>
> >
> > * symtab.c (lookup_partial_symtab): When looking up an absolute path
> > in the partial symtabs, compare the base names before checking the
> > full names.
We're only 3.5 months late reviewing this patch :-(... This looks OK
to me. I verified that this cannot create behavior changes due to
find_and_open_source returning a fullname with a different basename
(for instance if the source file was actually a link to another source
file): openp only canonicalizes the directory portion of the fullname.
So I think this is reasonable. Please go ahead and commit.
--
Joel
next prev parent reply other threads:[~2009-04-28 19:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 17:46 Jerome Guitton
2009-01-15 9:45 ` Jerome Guitton
2009-04-28 19:57 ` Joel Brobecker [this message]
2009-04-29 8:54 ` Jerome Guitton
2009-04-28 20:00 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090428195726.GA31821@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
--cc=guitton@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox