From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8983 invoked by alias); 28 Apr 2009 19:57:42 -0000 Received: (qmail 8974 invoked by uid 22791); 28 Apr 2009 19:57:42 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 28 Apr 2009 19:57:33 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AA2FD2BAB39; Tue, 28 Apr 2009 15:57:31 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id LlcP6O0bU9W0; Tue, 28 Apr 2009 15:57:31 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6CFD32BAC05; Tue, 28 Apr 2009 15:57:31 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id C81EDF5924; Tue, 28 Apr 2009 12:57:26 -0700 (PDT) Date: Tue, 28 Apr 2009 19:57:00 -0000 From: Joel Brobecker To: Jerome Guitton Cc: gdb-patches@sources.redhat.com Subject: Re: [Bug symtab/8367] [RFA] performance improvement of lookup_partial_symtab Message-ID: <20090428195726.GA31821@adacore.com> References: <20090114174542.GM84382@adacore.com> <20090115094511.GB80710@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090115094511.GB80710@adacore.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00765.txt.bz2 > > 2009-01-14 Jerome Guitton > > > > * symtab.c (lookup_partial_symtab): When looking up an absolute path > > in the partial symtabs, compare the base names before checking the > > full names. We're only 3.5 months late reviewing this patch :-(... This looks OK to me. I verified that this cannot create behavior changes due to find_and_open_source returning a fullname with a different basename (for instance if the source file was actually a link to another source file): openp only canonicalizes the directory portion of the fullname. So I think this is reasonable. Please go ahead and commit. -- Joel