Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit] prefer in-tree libiconv over the system libiconv
Date: Wed, 22 Apr 2009 16:22:00 -0000	[thread overview]
Message-ID: <20090422162201.GF5858@adacore.com> (raw)
In-Reply-To: <m3bpqpzi6p.fsf@fleche.redhat.com>

> Joel> The diff seems awful, but all I did was move the block for ../libiconv
> Joel> up before we check for iconv in the libc. And I made us check iconv
> Joel> in libc only if we haven't found iconv in ../libiconv.
> 
> The code change looks fine FWIW.

Thanks! I'll let this patch sit for a week, and then check it in,
if there aren't any objection.

I'm starting to use this method for my own builds, and I have to say
that it is really convenient. Dropped the libiconv sources in my source
tree once, and never have to remember how to configure GDB, or where
the lib[...] install is. I'd like to do the same for libexpat. Thoughts?

-- 
Joel


  reply	other threads:[~2009-04-22 16:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090420183619.GB5858@adacore.com>
     [not found] ` <m3fxg32fk6.fsf@fleche.redhat.com>
     [not found]   ` <20090420213559.GS2904@adacore.com>
2009-04-21 21:00     ` Joel Brobecker
2009-04-21 23:44       ` Tom Tromey
2009-04-22 16:22         ` Joel Brobecker [this message]
2009-04-22 17:13           ` Tom Tromey
2009-05-06 23:06       ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090422162201.GF5858@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox