From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27411 invoked by alias); 22 Apr 2009 16:22:26 -0000 Received: (qmail 27386 invoked by uid 22791); 22 Apr 2009 16:22:25 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Apr 2009 16:22:20 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 579152BAC56; Wed, 22 Apr 2009 12:22:16 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id qeOOJPVV53vS; Wed, 22 Apr 2009 12:22:16 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 49BF32BABF7; Wed, 22 Apr 2009 12:22:14 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id BF3EEF5886; Wed, 22 Apr 2009 09:22:01 -0700 (PDT) Date: Wed, 22 Apr 2009 16:22:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit] prefer in-tree libiconv over the system libiconv Message-ID: <20090422162201.GF5858@adacore.com> References: <20090420183619.GB5858@adacore.com> <20090420213559.GS2904@adacore.com> <20090421210032.GF23807@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00592.txt.bz2 > Joel> The diff seems awful, but all I did was move the block for ../libiconv > Joel> up before we check for iconv in the libc. And I made us check iconv > Joel> in libc only if we haven't found iconv in ../libiconv. > > The code change looks fine FWIW. Thanks! I'll let this patch sit for a week, and then check it in, if there aren't any objection. I'm starting to use this method for my own builds, and I have to say that it is really convenient. Dropped the libiconv sources in my source tree once, and never have to remember how to configure GDB, or where the lib[...] install is. I'd like to do the same for libexpat. Thoughts? -- Joel