Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: tromey@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: Add base linux native multi-process support.
Date: Mon, 20 Apr 2009 18:06:00 -0000	[thread overview]
Message-ID: <200904201906.41719.pedro@codesourcery.com> (raw)
In-Reply-To: <m3tz4ocsz1.fsf@fleche.redhat.com>

On Thursday 16 April 2009 20:13:22, Tom Tromey wrote:

> Pedro>  /* Call CALLBACK with its second argument set to DATA for every LWP in
> Pedro>     the list.  If CALLBACK returns 1 for a particular LWP, return a
> Pedro>     pointer to the structure describing that LWP immediately.
> Pedro>     Otherwise return NULL.  */
>  
> Pedro>  struct lwp_info *
> Pedro> -iterate_over_lwps (int (*callback) (struct lwp_info *, void *), void *data)
> Pedro> +iterate_over_lwps (ptid_t filter,
> Pedro> +		   int (*callback) (struct lwp_info *, void *),
> Pedro> +		   void *data)
> 
> Please update the function's comment to explain the new parameter.

Will do.  Thanks.

> 
> Pedro> Index: src/gdb/linux-thread-db.c
> 
> After reading Paul's patch and then yours, it occurs to me that the
> thread database .so dlopen handle and various function pointers will
> have to be per-inferior.

Yeah.  I was going to leave that for a follow up, but, his
patch looks close to go, so I'll rebase my patch when Paul's patch
goes in, and do that before reposting.

-- 
Pedro Alves


  reply	other threads:[~2009-04-20 18:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-07 19:55 Pedro Alves
2009-04-16 19:15 ` Tom Tromey
2009-04-20 18:06   ` Pedro Alves [this message]
2009-04-20 18:29     ` Tom Tromey
2009-05-18  2:26       ` Pedro Alves
2009-05-18  2:30         ` Pedro Alves
2009-05-18 13:45         ` Pedro Alves
2009-05-18 14:10           ` Pedro Alves
2009-05-18 17:10           ` Paul Pluzhnikov
2009-05-18 17:31             ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200904201906.41719.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox