From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1663 invoked by alias); 20 Apr 2009 18:06:25 -0000 Received: (qmail 1493 invoked by uid 22791); 20 Apr 2009 18:06:24 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 20 Apr 2009 18:06:17 +0000 Received: (qmail 22449 invoked from network); 20 Apr 2009 18:06:15 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 20 Apr 2009 18:06:15 -0000 From: Pedro Alves To: tromey@redhat.com Subject: Re: Add base linux native multi-process support. Date: Mon, 20 Apr 2009 18:06:00 -0000 User-Agent: KMail/1.9.10 Cc: gdb-patches@sourceware.org References: <200904072056.04727.pedro@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200904201906.41719.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00525.txt.bz2 On Thursday 16 April 2009 20:13:22, Tom Tromey wrote: > Pedro> /* Call CALLBACK with its second argument set to DATA for every LWP in > Pedro> the list. If CALLBACK returns 1 for a particular LWP, return a > Pedro> pointer to the structure describing that LWP immediately. > Pedro> Otherwise return NULL. */ > > Pedro> struct lwp_info * > Pedro> -iterate_over_lwps (int (*callback) (struct lwp_info *, void *), void *data) > Pedro> +iterate_over_lwps (ptid_t filter, > Pedro> + int (*callback) (struct lwp_info *, void *), > Pedro> + void *data) > > Please update the function's comment to explain the new parameter. Will do. Thanks. > > Pedro> Index: src/gdb/linux-thread-db.c > > After reading Paul's patch and then yours, it occurs to me that the > thread database .so dlopen handle and various function pointers will > have to be per-inferior. Yeah. I was going to leave that for a follow up, but, his patch looks close to go, so I'll rebase my patch when Paul's patch goes in, and do that before reposting. -- Pedro Alves