From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [commit/Ada] delete ada-lang.c:extract_string and use target_read_string instead
Date: Thu, 16 Apr 2009 23:32:00 -0000 [thread overview]
Message-ID: <20090416233236.GN7585@adacore.com> (raw)
In-Reply-To: <m3r5zs9puq.fsf@fleche.redhat.com>
> If it is always ascii then it is pretty safe as-is. gdb assumes that
> the host execution character set is ascii-compatible in several
> places. And, there is no validation or conversion of the character
> set used in the debug info. So, this isn't any worse than existing
> situations :-)
(I have a feeling that I'm going to develop some knowledge about
charsets - actually, you guys are already to developing some charset
knowledge in me :-)
OK - if it's safe as is for now, I'm going to be lazy and leave it
as is. But thanks for the review, definitely very much appreciated.
--
Joel
prev parent reply other threads:[~2009-04-16 23:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 17:19 Joel Brobecker
2009-04-16 22:19 ` Tom Tromey
2009-04-16 22:45 ` Joel Brobecker
2009-04-16 22:49 ` Tom Tromey
2009-04-16 23:32 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090416233236.GN7585@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox