From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16308 invoked by alias); 16 Apr 2009 23:32:49 -0000 Received: (qmail 16300 invoked by uid 22791); 16 Apr 2009 23:32:48 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 16 Apr 2009 23:32:43 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 4EDA82BAC32; Thu, 16 Apr 2009 19:32:41 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id IHeg14rMT8mI; Thu, 16 Apr 2009 19:32:41 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1EE092BABF6; Thu, 16 Apr 2009 19:32:41 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id B28F2F58C1; Thu, 16 Apr 2009 16:32:36 -0700 (PDT) Date: Thu, 16 Apr 2009 23:32:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [commit/Ada] delete ada-lang.c:extract_string and use target_read_string instead Message-ID: <20090416233236.GN7585@adacore.com> References: <20090416171914.GM7557@adacore.com> <20090416224507.GM7585@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00402.txt.bz2 > If it is always ascii then it is pretty safe as-is. gdb assumes that > the host execution character set is ascii-compatible in several > places. And, there is no validation or conversion of the character > set used in the debug info. So, this isn't any worse than existing > situations :-) (I have a feeling that I'm going to develop some knowledge about charsets - actually, you guys are already to developing some charset knowledge in me :-) OK - if it's safe as is for now, I'm going to be lazy and leave it as is. But thanks for the review, definitely very much appreciated. -- Joel