From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Pedro Alves <pedro@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [commit] Fix compilation warning in procfs.c on mips-irix
Date: Thu, 16 Apr 2009 19:52:00 -0000 [thread overview]
Message-ID: <20090416195153.GA19478@caradoc.them.org> (raw)
In-Reply-To: <20090416184539.GI7585@adacore.com>
On Thu, Apr 16, 2009 at 11:45:39AM -0700, Joel Brobecker wrote:
> > - return (*func) ((CORE_ADDR) map->pr_vaddr,
> > + return (*func) ((CORE_ADDR) (uintptr_t) map->pr_vaddr,
> > map->pr_size,
> > (map->pr_mflags & MA_READ) != 0,
> > (map->pr_mflags & MA_WRITE) != 0,
> >
> > Isn't this a problem for MIPS, due to pointer sign-extension?
>
> Hmmm, you are probably right. I reverted the patch for now, and will look
> further into your suggestion a bit later.
Note, if you don't have any code above 0x80000000, it doesn't much
matter... I don't remember how the MIPS bits ever came to be used, or
if they were theoretical. Threaded code on 32-bit MIPS Linux is
always going to be below KSEG0 at 0x80000000.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-04-16 19:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 17:30 Joel Brobecker
2009-04-16 18:24 ` Pedro Alves
2009-04-16 18:45 ` Joel Brobecker
2009-04-16 19:52 ` Daniel Jacobowitz [this message]
2009-04-17 13:27 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090416195153.GA19478@caradoc.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox