From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32576 invoked by alias); 16 Apr 2009 19:52:05 -0000 Received: (qmail 32567 invoked by uid 22791); 16 Apr 2009 19:52:04 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 16 Apr 2009 19:51:57 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 32BA27C09D; Thu, 16 Apr 2009 19:51:55 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id F34D11075A; Thu, 16 Apr 2009 19:51:54 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1LuXcn-000560-72; Thu, 16 Apr 2009 15:51:53 -0400 Date: Thu, 16 Apr 2009 19:52:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [commit] Fix compilation warning in procfs.c on mips-irix Message-ID: <20090416195153.GA19478@caradoc.them.org> Mail-Followup-To: Joel Brobecker , Pedro Alves , gdb-patches@sourceware.org References: <20090416173025.GO7557@adacore.com> <200904161924.52037.pedro@codesourcery.com> <20090416184539.GI7585@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090416184539.GI7585@adacore.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00387.txt.bz2 On Thu, Apr 16, 2009 at 11:45:39AM -0700, Joel Brobecker wrote: > > - return (*func) ((CORE_ADDR) map->pr_vaddr, > > + return (*func) ((CORE_ADDR) (uintptr_t) map->pr_vaddr, > > map->pr_size, > > (map->pr_mflags & MA_READ) != 0, > > (map->pr_mflags & MA_WRITE) != 0, > > > > Isn't this a problem for MIPS, due to pointer sign-extension? > > Hmmm, you are probably right. I reverted the patch for now, and will look > further into your suggestion a bit later. Note, if you don't have any code above 0x80000000, it doesn't much matter... I don't remember how the MIPS bits ever came to be used, or if they were theoretical. Threaded code on 32-bit MIPS Linux is always going to be below KSEG0 at 0x80000000. -- Daniel Jacobowitz CodeSourcery