libiberty configuration for DJGPP

libiberty configuration for DJGPP

[Eli Zaretskii]

The current libiberty misconfigures itself for native DJGPP builds,
because it tries to avoid compiling and linking test programs, for
cross-compilation's sake.  But the necessary bits that tell the
configure script what functions are available in the DJGPP library are
in the wrong place: the one that is run during the native build as
well, and there's no reason to avoid linking in that case.  The result
is that the native DJGPP build of GDB is unnecessarily broken, because
GDB needs several functions from libiberty that are unavailable in the
DJGPP library, but are not auto-detected.

The suggested patch below fixes that by moving the explicit list of
known functions to a place that only gets run when cross-compiling.
While at that, I also added to that part the functions needed by GDB
which need to be provided by libiberty.  The native build will now
auto-detect all the required functions.

2009-04-14  Eli Zaretskii  <eliz@gnu.org>

	* configure.ac  (setobjs, msdosdjgpp): Move a-priori setting of
	existing and required library functions to with_target_subdir
	section, so that the native build does detect them at configure
	time.

--- configure.a~0	2009-04-08 22:42:57.000000000 +0300
+++ configure.ac	2009-04-14 15:14:46.000000000 +0300
@@ -469,6 +469,28 @@
     setobjs=yes
     ;;
 
+  *-*-msdosdjgpp)
+    AC_LIBOBJ([vasprintf])
+    AC_LIBOBJ([vsnprintf])
+    AC_LIBOBJ([snprintf])
+    AC_LIBOBJ([asprintf])
+
+    for f in atexit basename bcmp bcopy bsearch bzero calloc clock ffs \
+             getcwd getpagesize getrusage gettimeofday \
+             index insque memchr memcmp memcpy memmove memset psignal \
+             putenv random rename rindex sbrk setenv stpcpy strcasecmp \
+             strchr strdup strerror strncasecmp strrchr strstr strtod \
+             strtol strtoul sysconf times tmpnam vfprintf vprintf \
+             vsprintf waitpid
+    do
+      n=HAVE_`echo $f | tr 'abcdefghijklmnopqrstuvwxyz' 'ABCDEFGHIJKLMNOPQRSTUVWXYZ'`
+      AC_DEFINE_UNQUOTED($n)
+    done
+
+
+    setobjs=yes
+    ;;
+
   esac
 
   # We may wish to install the target headers somewhere.
@@ -548,23 +570,6 @@
     setobjs=yes
     ;;
 
-  *-*-msdosdjgpp)
-    for f in atexit basename bcmp bcopy bsearch bzero calloc clock ffs \
-             getcwd getpagesize getrusage gettimeofday \
-             index insque memchr memcmp memcpy memmove memset psignal \
-             putenv random rename rindex sbrk setenv stpcpy strcasecmp \
-             strchr strdup strerror strncasecmp strrchr strstr strtod \
-             strtol strtoul sysconf times tmpnam vfprintf vprintf \
-             vsprintf waitpid
-    do
-      n=HAVE_`echo $f | tr 'abcdefghijklmnopqrstuvwxyz' 'ABCDEFGHIJKLMNOPQRSTUVWXYZ'`
-      AC_DEFINE_UNQUOTED($n)
-    done
-
-
-    setobjs=yes
-    ;;
-
   esac
 fi
 

Re: libiberty configuration for DJGPP

[Ian Lance Taylor]

Eli Zaretskii <eliz@gnu.org> writes:

> 2009-04-14  Eli Zaretskii  <eliz@gnu.org>
>
> 	* configure.ac  (setobjs, msdosdjgpp): Move a-priori setting of
> 	existing and required library functions to with_target_subdir
> 	section, so that the native build does detect them at configure
> 	time.

This is OK.

Thanks.

In the future, please send patches only to gcc-patches@, not to both
gcc-patches@ and gcc@.  Thanks.

Ian

Re: libiberty configuration for DJGPP

[Eli Zaretskii]

> Cc: gcc@gcc.gnu.org, gcc-patches@gcc.gnu.org, DJ Delorie <dj@redhat.com>,
>         gdb-patches@sources.redhat.com
> From: Ian Lance Taylor <iant@google.com>
> Date: Tue, 14 Apr 2009 07:22:25 -0700
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > 2009-04-14  Eli Zaretskii  <eliz@gnu.org>
> >
> > 	* configure.ac  (setobjs, msdosdjgpp): Move a-priori setting of
> > 	existing and required library functions to with_target_subdir
> > 	section, so that the native build does detect them at configure
> > 	time.
> 
> This is OK.

Is sources.redhat.com:/cvs/src the master repository for this file?
If not, I'm not sure I have write access to commit these changes.

> In the future, please send patches only to gcc-patches@, not to both
> gcc-patches@ and gcc@.  Thanks.

Will do, and sorry for the extra noise.

Thanks.

Re: libiberty configuration for DJGPP

[Ian Lance Taylor]

Eli Zaretskii <eliz@gnu.org> writes:

>> Cc: gcc@gcc.gnu.org, gcc-patches@gcc.gnu.org, DJ Delorie <dj@redhat.com>,
>>         gdb-patches@sources.redhat.com
>> From: Ian Lance Taylor <iant@google.com>
>> Date: Tue, 14 Apr 2009 07:22:25 -0700
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> > 2009-04-14  Eli Zaretskii  <eliz@gnu.org>
>> >
>> > 	* configure.ac  (setobjs, msdosdjgpp): Move a-priori setting of
>> > 	existing and required library functions to with_target_subdir
>> > 	section, so that the native build does detect them at configure
>> > 	time.
>> 
>> This is OK.
>
> Is sources.redhat.com:/cvs/src the master repository for this file?
> If not, I'm not sure I have write access to commit these changes.

No, the master repository is the gcc.gnu.org Subversion repository.
Anybody want to volunteer to commit this patch?

(By the way, sources.redhat.com is the old name.  sourceware.org is
preferred.)

Ian

Re: libiberty configuration for DJGPP

[Eli Zaretskii]

> Cc: gcc-patches@gcc.gnu.org, dj@redhat.com, gdb-patches@sources.redhat.com
> From: Ian Lance Taylor <iant@google.com>
> Date: Tue, 14 Apr 2009 07:55:36 -0700
> 
> (By the way, sources.redhat.com is the old name.  sourceware.org is
> preferred.)

OK, I switched my scripts to use that one instead.

[RFC] change sources.redhat.com to sourceware.org in gdbadmin/ss dir (was: libiberty configuration for DJGPP)

[Pierre Muller]

Hi Ian,

> (By the way, sources.redhat.com is the old name.  sourceware.org is
> preferred.)
> 
> Ian

  Shouldn't we update 
the files in ss directory, then?

I am not really sure about insight reference in README,
as this is still seems to be more a redhat
than a GNU project.



Pierre Muller
Pascal language support maintainer for GDB

PS: main src directory and many subdirectories 
seem to be in the need of similar changes...


Index: README
===================================================================
RCS file: /cvs/gdbadmin/ss/README,v
retrieving revision 1.6
diff -u -r1.6 README
--- README      29 Mar 2004 13:55:09 -0000      1.6
+++ README      14 Apr 2009 15:34:03 -0000
@@ -1,20 +1,20 @@
            GDB and INSIGHT Snapshot directory.
-       ftp://sources.redhat.com/pub/gdb/snapshots/
+       ftp://sourceware.org/pub/gdb/snapshots/

 See also:
-       http://sources.redhat.com/gdb
-       http://sources.redhat.com/insight
+       http://sourceware.org/gdb
+       http://sourceware.org/insight

 To unpack a snap-shot you will need the BZIP2 program.  See:

-       http://sources.redhat.com/bzip2/
-  and  ftp://sources.redhat.com/pub/bzip2
+       http://sourceware.org/bzip2/
+  and  ftp://sourceware.org/pub/bzip2

 For rebuilding GDB snapshots, several useful utilities (especially
 automake) are available:

-       ftp://sources.redhat.com/pub/gdb/infrastructure/
-  and  ftp://sources.redhat.com/pub/binutils/
+       ftp://sourceware.org/pub/gdb/infrastructure/
+  and  ftp://sourceware.org/pub/binutils/

 The following snapshots are available:

Index: do-ss
===================================================================
RCS file: /cvs/gdbadmin/ss/do-ss,v
retrieving revision 1.15
diff -u -r1.15 do-ss
--- do-ss       28 Apr 2005 23:13:49 -0000      1.15
+++ do-ss       14 Apr 2009 15:34:03 -0000
@@ -17,7 +17,7 @@

 sssh ()
 {
-    ssh -o 'Protocol 2' gdbadmin@sources.redhat.com "$@"
+    ssh -o 'Protocol 2' gdbadmin@sourceware.org "$@"
 }

 sssh mkdir -p ${tmpdir}
@@ -46,7 +46,7 @@
                --exclude='old*' \
                --exclude='ari.html' \
                --rsh='ssh -2' \
-               gdbadmin@sources.redhat.com:${wwwdir}/* /tmp/ari
+               gdbadmin@sourceware.org:${wwwdir}/* /tmp/ari
            ;;
        esac
     done
Index: do-scp
===================================================================
RCS file: /cvs/gdbadmin/ss/do-scp,v
retrieving revision 1.2
diff -u -r1.2 do-scp
--- do-scp      23 Oct 2002 21:15:16 -0000      1.2
+++ do-scp      14 Apr 2009 15:34:03 -0000
@@ -8,4 +8,4 @@
        --delete \
        --rsync-path=/usr/local/bin/rsync \
        --rsh='ssh -2' \
-       . gdbadmin@sources.redhat.com:ss
+       . gdbadmin@sourceware.org:ss
Index: make-snapshot
===================================================================
RCS file: /cvs/gdbadmin/ss/make-snapshot,v
retrieving revision 1.9
diff -u -r1.9 make-snapshot
--- make-snapshot       9 Jan 2004 21:59:44 -0000       1.9
+++ make-snapshot       14 Apr 2009 15:34:03 -0000
@@ -58,7 +58,7 @@
 echo "Replace root with sourceware root ..."
 find ${root} -name Root | while read f
 do
-    echo ":pserver:anoncvs@sources.redhat.com:/cvs/src" > $f
+    echo ":pserver:anoncvs@sourceware.org:/cvs/src" > $f
 done

 echo "`date`: Create CVS tarball ..."

Re: [RFC] change sources.redhat.com to sourceware.org in gdbadmin/ss dir (was: libiberty configuration for DJGPP)

[Joel Brobecker]

> Shouldn't we update the files in ss directory, then?

That's a good suggestion. For insight, you could check on the insight
mailing list. I'm pretty confident they'll be OK with the change.


-- 
Joel

RE: [RFC] change sources.redhat.com to sourceware.org in gdbadmin/ss dir (was: libiberty configuration for DJGPP)

[Pierre Muller]

As Keith also gave his approval for the insight part,
I committed the change to the ss directory.


Pierre Muller
Pascal language support maintainer for GDB




> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Joel Brobecker
> Envoyé : Tuesday, April 14, 2009 6:06 PM
> À : Pierre Muller
> Cc : 'Ian Lance Taylor'; 'Eli Zaretskii'; gdb-patches@sourceware.org
> Objet : Re: [RFC] change sources.redhat.com to sourceware.org in
> gdbadmin/ss dir (was: libiberty configuration for DJGPP)
> 
> > Shouldn't we update the files in ss directory, then?
> 
> That's a good suggestion. For insight, you could check on the insight
> mailing list. I'm pretty confident they'll be OK with the change.
> 
> 
> --
> Joel

[RFC] change sources.redhat.com to sourceware.org in gdbadmin/ss dir (was: libiberty configuration for DJGPP)

[Pierre Muller]

I proposed this patch for gdbadmin/ss directory

Ian tought it was a good idea, and added that I should ask 
directly on insight mailing list about this issue I raised:

I am not really sure about insight reference in README,
as this is still seems to be more a redhat
than a GNU project.

  Should we leave sources.redhat.com for all insight 
related references or also switch to sourceware.org?




Pierre Muller
Pascal language support maintainer for GDB

PS: main src directory and many subdirectories 
seem to be in the need of similar changes...


Index: README
===================================================================
RCS file: /cvs/gdbadmin/ss/README,v
retrieving revision 1.6
diff -u -r1.6 README
--- README      29 Mar 2004 13:55:09 -0000      1.6
+++ README      14 Apr 2009 15:34:03 -0000
@@ -1,20 +1,20 @@
            GDB and INSIGHT Snapshot directory.
-       ftp://sources.redhat.com/pub/gdb/snapshots/
+       ftp://sourceware.org/pub/gdb/snapshots/

 See also:
-       http://sources.redhat.com/gdb
-       http://sources.redhat.com/insight
+       http://sourceware.org/gdb
+       http://sourceware.org/insight

 To unpack a snap-shot you will need the BZIP2 program.  See:

-       http://sources.redhat.com/bzip2/
-  and  ftp://sources.redhat.com/pub/bzip2
+       http://sourceware.org/bzip2/
+  and  ftp://sourceware.org/pub/bzip2

 For rebuilding GDB snapshots, several useful utilities (especially
 automake) are available:

-       ftp://sources.redhat.com/pub/gdb/infrastructure/
-  and  ftp://sources.redhat.com/pub/binutils/
+       ftp://sourceware.org/pub/gdb/infrastructure/
+  and  ftp://sourceware.org/pub/binutils/

 The following snapshots are available:

Index: do-ss
===================================================================
RCS file: /cvs/gdbadmin/ss/do-ss,v
retrieving revision 1.15
diff -u -r1.15 do-ss
--- do-ss       28 Apr 2005 23:13:49 -0000      1.15
+++ do-ss       14 Apr 2009 15:34:03 -0000
@@ -17,7 +17,7 @@

 sssh ()
 {
-    ssh -o 'Protocol 2' gdbadmin@sources.redhat.com "$@"
+    ssh -o 'Protocol 2' gdbadmin@sourceware.org "$@"
 }

 sssh mkdir -p ${tmpdir}
@@ -46,7 +46,7 @@
                --exclude='old*' \
                --exclude='ari.html' \
                --rsh='ssh -2' \
-               gdbadmin@sources.redhat.com:${wwwdir}/* /tmp/ari
+               gdbadmin@sourceware.org:${wwwdir}/* /tmp/ari
            ;;
        esac
     done
Index: do-scp
===================================================================
RCS file: /cvs/gdbadmin/ss/do-scp,v
retrieving revision 1.2
diff -u -r1.2 do-scp
--- do-scp      23 Oct 2002 21:15:16 -0000      1.2
+++ do-scp      14 Apr 2009 15:34:03 -0000
@@ -8,4 +8,4 @@
        --delete \
        --rsync-path=/usr/local/bin/rsync \
        --rsh='ssh -2' \
-       . gdbadmin@sources.redhat.com:ss
+       . gdbadmin@sourceware.org:ss
Index: make-snapshot
===================================================================
RCS file: /cvs/gdbadmin/ss/make-snapshot,v
retrieving revision 1.9
diff -u -r1.9 make-snapshot
--- make-snapshot       9 Jan 2004 21:59:44 -0000       1.9
+++ make-snapshot       14 Apr 2009 15:34:03 -0000
@@ -58,7 +58,7 @@
 echo "Replace root with sourceware root ..."
 find ${root} -name Root | while read f
 do
-    echo ":pserver:anoncvs@sources.redhat.com:/cvs/src" > $f
+    echo ":pserver:anoncvs@sourceware.org:/cvs/src" > $f
 done

 echo "`date`: Create CVS tarball ..."

Re: [RFC] change sources.redhat.com to sourceware.org in gdbadmin/ss dir (was: libiberty configuration for DJGPP)

[Christopher Faylor]

On Tue, Apr 14, 2009 at 06:25:46PM +0200, Pierre Muller wrote:
>I proposed this patch for gdbadmin/ss directory
>
>Ian tought it was a good idea, and added that I should ask 
>directly on insight mailing list about this issue I raised:
>
>I am not really sure about insight reference in README,
>as this is still seems to be more a redhat
>than a GNU project.
>
>Should we leave sources.redhat.com for all insight related references
>or also switch to sourceware.org?

The name of the site really is sourceware.org but insight isn't really
officially supported by Red Hat anymore (and hasn't been for years) so I
don't see any reason to keep the .redhat.com for insight's sake.

If we were talking about something like systemtap or frysk then that
would be a different story...

cgf

Re: libiberty configuration for DJGPP

[DJ Delorie]

> Anybody want to volunteer to commit this patch?

I committed it.

Re: libiberty configuration for DJGPP

[Eli Zaretskii]

> Date: Tue, 14 Apr 2009 13:46:35 -0400
> From: DJ Delorie <dj@redhat.com>
> CC: eliz@gnu.org, gcc-patches@gcc.gnu.org, gdb-patches@sources.redhat.com
> 
> 
> > Anybody want to volunteer to commit this patch?
> 
> I committed it.

Thanks.