From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>
Subject: Re: [RFA] Fix crash on Linux 2.4 when threaded program exits
Date: Wed, 01 Apr 2009 18:42:00 -0000 [thread overview]
Message-ID: <200904011942.40306.pedro@codesourcery.com> (raw)
In-Reply-To: <20090401182220.GG16605@adacore.com>
On Wednesday 01 April 2009 19:22:20, Joel Brobecker wrote:
> 2009-04-01 Joel Brobecker <brobecker@adacore.com>
>
> * linux-nat.c (linux_nat_filter_events): Do not delete the lwp if
> this is the last one.
>
> Tested on x86-linux (with a 2.4.21 Linux kernel). It fixes ~25 failures.
> Tested on x86_64-linux (with a 2.6 kernel). No regression.
>
> Does this look correct?
Yes, this is OK.
The comments about ntpl and thread exit notifications on nptl
are confusing to a reader considering Linux 2.6. They could do
with a:
s/In the nptl thread model/In the nptl thread model on Linux 2.4/.
wait_lwp does mention this 2.4 + backported nptl artifact explicitly.
--
Pedro Alves
next prev parent reply other threads:[~2009-04-01 18:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-01 18:22 Joel Brobecker
2009-04-01 18:42 ` Pedro Alves [this message]
2009-04-01 18:58 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904011942.40306.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox