From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24115 invoked by alias); 1 Apr 2009 18:42:40 -0000 Received: (qmail 24103 invoked by uid 22791); 1 Apr 2009 18:42:39 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Apr 2009 18:42:34 +0000 Received: (qmail 6514 invoked from network); 1 Apr 2009 18:42:32 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 1 Apr 2009 18:42:32 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] Fix crash on Linux 2.4 when threaded program exits Date: Wed, 01 Apr 2009 18:42:00 -0000 User-Agent: KMail/1.9.10 Cc: Joel Brobecker References: <20090401182220.GG16605@adacore.com> In-Reply-To: <20090401182220.GG16605@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200904011942.40306.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00006.txt.bz2 On Wednesday 01 April 2009 19:22:20, Joel Brobecker wrote: > 2009-04-01 Joel Brobecker > > * linux-nat.c (linux_nat_filter_events): Do not delete the lwp if > this is the last one. > > Tested on x86-linux (with a 2.4.21 Linux kernel). It fixes ~25 failures. > Tested on x86_64-linux (with a 2.6 kernel). No regression. > > Does this look correct? Yes, this is OK. The comments about ntpl and thread exit notifications on nptl are confusing to a reader considering Linux 2.6. They could do with a: s/In the nptl thread model/In the nptl thread model on Linux 2.4/. wait_lwp does mention this 2.4 + backported nptl artifact explicitly. -- Pedro Alves