From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>
Subject: Re: [RFA/commit] Minor cleanup in breakpoint_thread_match
Date: Wed, 25 Mar 2009 19:25:00 -0000 [thread overview]
Message-ID: <200903251811.35835.pedro@codesourcery.com> (raw)
In-Reply-To: <20090325180033.GB9472@adacore.com>
On Wednesday 25 March 2009 18:00:33, Joel Brobecker wrote:
> > 2009-03-25 Joel Brobecker <brobecker@adacore.com>
> >
> > * breakpoint.c (breakpoint_thread_match): Split a large condition
> > into several smaller conditions. No behavior change.
> >
> > Tested on x86_64-linux. I made this change in a pretty procedural and
> > mechanical way. But a second pair of eyes would be appreciated. Plus,
> > I'd like to know if others also prefer splitting this condition like
> > I did.
>
> Actually, upon rewriting the Ada patch, it occured to me that the
> following is even more helpful in inserting support for task-specific
> breakpoints... I'm currently testing the attached patch.
>
Looks sane to me.
--
Pedro Alves
next prev parent reply other threads:[~2009-03-25 18:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 18:00 Joel Brobecker
2009-03-25 18:12 ` Joel Brobecker
2009-03-25 19:25 ` Pedro Alves [this message]
2009-03-25 22:12 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903251811.35835.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox