From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9875 invoked by alias); 25 Mar 2009 18:12:09 -0000 Received: (qmail 9867 invoked by uid 22791); 25 Mar 2009 18:12:08 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Mar 2009 18:12:03 +0000 Received: (qmail 31440 invoked from network); 25 Mar 2009 18:11:38 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 25 Mar 2009 18:11:38 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA/commit] Minor cleanup in breakpoint_thread_match Date: Wed, 25 Mar 2009 19:25:00 -0000 User-Agent: KMail/1.9.10 Cc: Joel Brobecker References: <20090325174911.GA9472@adacore.com> <20090325180033.GB9472@adacore.com> In-Reply-To: <20090325180033.GB9472@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200903251811.35835.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00557.txt.bz2 On Wednesday 25 March 2009 18:00:33, Joel Brobecker wrote: > > 2009-03-25 Joel Brobecker > > > > * breakpoint.c (breakpoint_thread_match): Split a large condition > > into several smaller conditions. No behavior change. > > > > Tested on x86_64-linux. I made this change in a pretty procedural and > > mechanical way. But a second pair of eyes would be appreciated. Plus, > > I'd like to know if others also prefer splitting this condition like > > I did. > > Actually, upon rewriting the Ada patch, it occured to me that the > following is even more helpful in inserting support for task-specific > breakpoints... I'm currently testing the attached patch. > Looks sane to me. -- Pedro Alves